Skip to content
GitLab
Menu
Projects
Groups
Snippets
Help
Help
Support
Community forum
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
Menu
Open sidebar
Nathan OBrian
Nebulo
Commits
91c3f1d5
Commit
91c3f1d5
authored
Jun 02, 2021
by
Daniel Wolf
Browse files
Fix no rule being deleted when no source is selected
parent
7d52441c
Changes
2
Hide whitespace changes
Inline
Side-by-side
app/src/main/java/com/frostnerd/smokescreen/database/dao/DnsRuleDao.kt
View file @
91c3f1d5
...
...
@@ -45,8 +45,11 @@ interface DnsRuleDao {
@Query
(
"DELETE FROM DnsRule WHERE importedFrom IS NULL"
)
fun
deleteAllUserRules
()
@Query
(
"UPDATE DnsRule SET stagingType=1 WHERE importedFrom IS NOT NULL AND stagingType=0 AND importedFrom IN(:sources)"
)
fun
markNonUserRulesForDeletion
(
sources
:
List
<
Long
>)
@Query
(
"DELETE FROM DnsRule WHERE importedFrom IS NOT NULL"
)
fun
deleteAllNonUserRules
()
@Query
(
"UPDATE DnsRule SET stagingType=1 WHERE importedFrom IS NOT NULL AND stagingType=0"
)
fun
markNonUserRulesForDeletion
()
@Query
(
"UPDATE DnsRule SET stagingType=0 WHERE importedFrom=:hostSourceId AND stagingType=1"
)
fun
unstageRulesOfSource
(
hostSourceId
:
Long
)
...
...
app/src/main/java/com/frostnerd/smokescreen/service/RuleImportService.kt
View file @
91c3f1d5
...
...
@@ -174,7 +174,7 @@ class RuleImportService : IntentService("RuleImportService") {
private
fun
startWork
()
{
val
dnsRuleDao
=
getDatabase
().
dnsRuleDao
()
dnsRuleDao
.
markNonUserRulesForDeletion
(
sourcesIds
)
// Stage all, ignoring if the source is actually processed in this run
dnsRuleDao
.
markNonUserRulesForDeletion
()
// Stage all, ignoring if the source is actually processed in this run
dnsRuleDao
.
deleteStagedRules
()
var
count
=
0
val
newChecksums
=
mutableMapOf
<
HostSource
,
String
>()
...
...
@@ -244,7 +244,7 @@ class RuleImportService : IntentService("RuleImportService") {
updateNotificationFinishing
()
log
(
"Delete rules staged for deletion"
)
dnsRuleDao
.
deleteMarkedRules
()
log
(
"Commiting staging"
)
log
(
"Commit
t
ing staging"
)
dnsRuleDao
.
commitStaging
()
dnsRuleDao
.
deleteStagedRules
()
log
(
"Recreating database indices"
)
...
...
Write
Preview
Supports
Markdown
0%
Try again
or
attach a new file
.
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment